search

AppImageCommunity / libappimage

Implements functionality for dealing with AppImage files
https://appimage.org
Other
46 stars 27 forks source link

Fix libappimage_static #99

Open azubieta opened 5 years ago

azubieta commented 5 years ago

Install and export the libappimage_static target.

Move the appimage_registered_desktop_file_path function into libappimmage.cpp and use C++ on it.

TheAssassin commented 5 years ago

If you still want to merge this, you need to fix the PR.

azubieta commented 5 years ago

Reference #76

Ideally, a binary with the lowest amount of dependencies must be provided the libappimage user. But, due to the large range of possible configurations keeping the track and bundling (in some cases it would be a bad idea do bundle other static libraries) of each dependency turns into a complex task.

The current proposal left the dependencies management to the libappimage user so they will be responsible for resolving all of them (including libsquashfuse).

azubieta commented 5 years ago

why this was closed?

TheAssassin commented 5 years ago

You wrote

fix #99

in the PR...

azubieta commented 5 years ago

My bad, that pr had nothing to do with this. Reference updated