search

AppImageCommunity / pkg2appimage

Tool and recipes to convert existing deb packages to AppImage
http://appimage.org
MIT License
685 stars 210 forks source link

If we customise the icons theme, will the icons of AppImages apps also change? #199

Closed gusbemacbe closed 5 years ago

gusbemacbe commented 7 years ago

Hello,

I am aware that the icons of AppImage apps do not change when we customise the icons theme. We can only change the icon of AppImage apps from the Nautilus when we open the app propriety. But Nautilus is the default of the only distribution of Ubuntu. Other Debian-based distributions, Arch Linux and Arch LInux-based distributions, openSUSE and other distributions of LInux do not use Nautilus as the default.

Will you make the future fix for the AppImage apps and suggest or train the developers to fix and add the new feature which allows the icons and the theme to be changed when we change icons theme and the theme?

probonopd commented 7 years ago

The current model is that the icon inside the AppImage is used and there is currently no support for multiple icon themes for the application icon at this time. If this is important to you, then you would have to write some code to allow for this, e.g., for the optional appimaged daemon. https://github.com/probonopd/AppImageKit

Or are you talking about icons inside the application?

gusbemacbe commented 7 years ago

Only apps icons, @probonopd. I do not know if I change the UI theme, the Appimage app also will change, for example, window menu.

Martina-Neumayer commented 5 years ago

@gusbemacbe Simple and easy way (the last one answer, at the bottom of the topic).. https://askubuntu.com/questions/902672/registering-appimage-files-as-a-desktop-app And such icon you can customize as you want to and it will change itself with the theme if the theme will have it inside, off course ;)

gusbemacbe commented 5 years ago

@Martina-Neumayer

The problem is that at KDE, when we open an AppImage, it opens the secondary window which comes with a fixed icon of X11, the primary window with normal icon is closed. It is not good.

Martina-Neumayer commented 5 years ago

@gusbemacbe Ahh.. okay.. I dosen't know that. I am using Mate on Arch with compiz as standalone dm. It can be also some x related issue or de related one. And yes.. it is not good, you're right.

Update: In Mate is way simplier.. even this described in the "askubuntu" tips.. Ppm on the .appimage file -> properties -> and in the new window, in the first tab just click on the icon picture to change it. Works great and without any x11 related issues.

probonopd commented 5 years ago

The problem is that at KDE, when we open an AppImage, it opens the secondary window which comes with a fixed icon of X11, the primary window with normal icon is closed.

Can you post a screenshot/animated GIF (e.g., using Peek AppImage)? How to reproduce? (Which app, version, OS?)

gusbemacbe commented 5 years ago

Can you post a screenshot/animated GIF (e.g., using Peek AppImage)? How to reproduce? (Which app, version, OS?)

It is not only one app. It affects many AppImage-built apps - FontBase, Gravit Designer, Joplin, Stellarium, etc. Mostly in KDE and in Deepin Environment because they do not interact well with or hold well the primary window with normal icon.

In GNOME and any DEs based on GNOME (Cinnamon, MATE, etc.), they open normally the primary window with normal icon.

Let me explain using ones AppImages FontBase, recording with Peek:

appimage example 1

In this record:

  1. When I open the AppImage, it opens with the icon of X11.
  2. When I add a desktop file of AppImage to the dock, and when I open this desktop file (primary window), it opens the secondary window with the icon of X11 and closes the primary.

Observe that it is not exclusive of Latte Dock, it also happens in Plank and in the Plasma Panel. It also affects Deepin Environment dock.

gusbemacbe commented 5 years ago

I address you to the issue https://discuss.gravit.io/t/linux-package-feature-requests/294/20?u=gustavoreis. You can click the image I showed. In the image, I open Gravit Designer AppImage desktop file, but it opens the secondary window with different icon and closes the Gravit desktop file. It was in KDE in Ubuntu.

probonopd commented 5 years ago

Please check the following 2 things,

Both should be true for it to work properly.

Reference: https://github.com/electron-userland/electron-builder/issues/2098

gusbemacbe commented 5 years ago

Does the desktop file have the correct StartupWMClass= entry?

I have just tested FontBase and Joplin, they do not have this entry, here are the result of desktop files:

[Desktop Action Remove] Name=Remove AppImage from system Exec=/usr/lib/appimagelauncher/remove /home/gusbemacbe/Applications/Joplin_545a382c66c086a7e1f1ad718398d04b.AppImage Name[de]=AppImage vom System entfernen Name[en]=Remove AppImage from system Name[es]=Eliminar Appimage del Sistema Name[fr]=Supprimer l'AppImage du système Name[ru]=Удалить AppImage из системы

[Desktop Action Update] Name=Update AppImage Exec=/usr/lib/appimagelauncher/update /home/gusbemacbe/Applications/Joplin_545a382c66c086a7e1f1ad718398d04b.AppImage Name[de]=AppImage aktualisieren Name[en]=Update AppImage Name[es]=Actualizar Appimage Name[fr]=Mettre à jour l'AppImage Name[ru]=Обновить AppImage


* FontBase

[Desktop Entry] Name=FontBase (2.6.1) Comment=A lightning fast, beautiful and free font manager for designers. Exec=/home/gusbemacbe/Applications/FontBase_96505226ce1aafcd26d1e58436f5f6c3.AppImage Terminal=false Type=Application Icon=appimagekit_c3b8d99648b2a5633b64c7ee0d5c559d_fontbase X-AppImage-Version=2.6.1 X-AppImage-BuildId=19e54580-b023-11a8-2170-bb9c855056fa Categories=Graphics; TryExec=/home/gusbemacbe/Applications/FontBase_96505226ce1aafcd26d1e58436f5f6c3.AppImage X-AppImage-Old-Icon=fontbase X-AppImage-Old-Name=FontBase X-AppImage-Identifier=c3b8d99648b2a5633b64c7ee0d5c559d Actions=Remove;Update; X-AppImageLauncher-Version=1-alpha (git commit 9cd7f02), built on 2018-09-03 17:17:37 UTC

[Desktop Action Remove] Name=Remove AppImage from system Exec=/usr/lib/appimagelauncher/remove /home/gusbemacbe/Applications/FontBase_96505226ce1aafcd26d1e58436f5f6c3.AppImage Name[de]=AppImage vom System entfernen Name[en]=Remove AppImage from system Name[es]=Eliminar Appimage del Sistema Name[fr]=Supprimer l'AppImage du système Name[ru]=Удалить AppImage из системы

[Desktop Action Update] Name=Update AppImage Exec=/usr/lib/appimagelauncher/update /home/gusbemacbe/Applications/FontBase_96505226ce1aafcd26d1e58436f5f6c3.AppImage Name[de]=AppImage aktualisieren Name[en]=Update AppImage Name[es]=Actualizar Appimage Name[fr]=Mettre à jour l'AppImage Name[ru]=Обновить AppImage



> In Electron, is the icon option to the BrowserWindow set?

FontBase uses the Electron icon added insided its AppImage, named as fontbase. But other AppImages have own icons. Joplin uses the own Joplin icon, but its desktop file display incorrectly its icon, its icon is shown as "?". 

As for Gravit Designer, it has own Gravit Designer icon and its displays correctly the icon.
gusbemacbe commented 5 years ago

I have just tested StartupWMClass and it does not work.

probonopd commented 5 years ago

We are now deviating from the original subject of this ticket and are discussing multiple different applications' issues. To keep things apart:

  1. Regarding the original subject, "If we customise the icons theme, will the icons of AppImages apps also change?": An AppImage shall display the icons that are bundled inside the AppImage. Not what an icon theme in the system has. So that, for example, different versions of Firefox can have different icons, as defined inside the AppImage. The author of an AppImage should decide the icon, not the operating system the AppImage is running on. This is the intended (and working) behavior.

  2. Regarding individual AppImages that don't show their icons correctly, please open a ticket in the bug tracker of each application that does not have the correct behavior and please point me to those tickets.

Thanks!

gusbemacbe commented 5 years ago

OK, I am going to close this issue for not "necro-bumping" and diverting the issue.