AppImageCommunity / pkg2appimage

Tool and recipes to convert existing deb packages to AppImage
http://appimage.org
MIT License
684 stars 209 forks source link

Webex app (some help needed) #509

Closed Meister1593 closed 2 years ago

Meister1593 commented 2 years ago

Since Webex doesn't really provide any other way than using deb's and rpm's (and on aur it requires basically critical library (libcrypt) downgrade as of now), i decided to make appimage for it.

I almost did it, but ran into the problem with validating .desktop file

They included version of app into Version of .desktop file, which is of course, incorrect

I tried changing it in script section, but it always failed no matter what i did, so i come here for help

I suspect this issue is probably related to pkg2appimage workflow, but i wonder if i might have misunderstood something there, or maybe there's some workarounds.

If this is gonna be resolved, i want to make a pull request

Last lines with error:

+ desktop-file-validate ./opt/Webex/bin/webex.desktop
./opt/Webex/bin/webex.desktop: error: value "42.3.0.21576" for key "Version" in group "Desktop Entry" is not a known version
./opt/Webex/bin/webex.desktop: warning: value "Webex" for key "Comment" in group "Desktop Entry" looks redundant with value "Webex" of key "Name"
./opt/Webex/bin/webex.desktop: warning: value "Utility;Application;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
+ exit 1
Webex.yml ```yml app: Webex ingredients: dist: bionic packages: - binutils - xdg-utils - libgl1-mesa-glx - libnss3 - libnspr4 - libcups2 - upower - libnotify4 - libsecret-1-0 - libwayland-client0 - libatk1.0-0 - libatk-bridge2.0-0 - libgbm1 - libpango-1.0-0 - libpangocairo-1.0-0 - libatspi2.0-0 - libgssapi-krb5-2 - libasound2 - libudev1 - libpulse0 - libxcb-randr0 - libxcb-xfixes0 - libxcb-xinerama0 - libxcb-render-util0 - libxcb-keysyms1 - libxcb-image0 - libxcb-icccm4 - libxkbcommon-x11-0 sources: - deb http://us.archive.ubuntu.com/ubuntu/ bionic universe script: - wget https://binaries.webex.com/WebexDesktop-Ubuntu-Official-Package/Webex.deb - echo "42.3.0.21576" > VERSION # this line i kinda hardcoded for now, because i wasn't sure if that will help or not with my problem script: - sed -i -e 's|^Version=.*|Version=1.1|g' ./opt/Webex/bin/webex.desktop # here i tried changing Version into something else, and even removing this line with /g didn't work - cp ./opt/Webex/bin/webex.desktop . - ln -s ./opt/Webex/bin/CiscoCollabHost ./CiscoCollabHost - ln -s ./opt/Webex/bin/sparklogosmall.png ./sparklogosmall.png - sed -i -e 's|^Exec=.*|Exec=CiscoCollabHost|g' webex.desktop - sed -i -e 's|^Icon=.*|Icon=sparklogosmall.png|g' webex.desktop - cp ./opt/Webex/bin/sparklogosmall.png . ```
webex.desktop ```desktop [Desktop Entry] Version=42.3.0.21576 Name=Webex Comment=Webex Exec=/opt/Webex/bin/CiscoCollabHost %U Icon=/opt/Webex/bin/sparklogosmall.png Terminal=false Type=Application Categories=Utility;Application; MimeType=x-scheme-handler/webexteams ```
probonopd commented 2 years ago

Delete the Version=... line in the desktop file.

Meister1593 commented 2 years ago

Delete the Version=... line in the desktop file.

i can't, it's inside deb file, i don't want to repackage it

Meister1593 commented 2 years ago

Sorry for inconvenience, i didn't actually use the file i changed, it was in other place and i always tried building with same .yml file Issue may be closed, pull request for Webex app will be shortly

probonopd commented 2 years ago

Value "42.3.0.21576" for key "Version" is plain wrong, though ;-)