search

AppImageCommunity / pkg2appimage

Tool and recipes to convert existing deb packages to AppImage
http://appimage.org
MIT License
684 stars 209 forks source link

Use ubuntu 18.04 for to create the appimage #545

Closed uli-heller closed 8 months ago

uli-heller commented 9 months ago

This enables using pkg2appimage within builds based on ubuntu-18.04 (bionic) which is for example used by vscodium

Fixes #544

probonopd commented 9 months ago

Hi @uli-heller, thanks for your PR. Is there any chance to do this without the need for

container:

?

uli-heller commented 9 months ago

Hi @uli-heller, thanks for your PR. Is there any chance to do this without the need for

container:

?

Hey @probonopd , at the moment, I'm not sure how to achieve the goal without the additional container. I need an ubuntu-18.04 environment for the fix to work. Without container:, only ubuntu-20.04, ubuntu-22.04 and ubuntu-latest (=ubuntu-22.04 at this time) are available to my knowledge. Do you know more details? A custom gitlab runner might be an option, too. Best regards, Uli

probonopd commented 8 months ago

Using 20.04 should be fine now, since 18.04 is no longer in standard support. https://ubuntu.com/about/release-cycle

GitMensch commented 8 months ago

Microsoft still uses 18.04 (which still gets 5 years of extended support) for their Visual Studio Code containers. VSCodium uses a derived one - and if possible we really like to keep the compatibility this brings (see related issue in VSCodium).

Without this PR this means we'd either need to use the forked one which intends to be integrated (and therefore isn't up to date) or an outdated version of pkg2appimage (earlier than 2023-09-10).

probonopd commented 8 months ago

Thank you both for the explanation and implementation.