AppImageCommunity / pkg2appimage

Tool and recipes to convert existing deb packages to AppImage
http://appimage.org
MIT License
684 stars 209 forks source link

Fixed correct handling of OBS repositories as debian source #550

Closed csoler closed 5 months ago

csoler commented 6 months ago

Took me a while to find this, but according to the pkg2appimage documentation, Debian repositories from the opensuse build system should be listed as:

dist: [ubuntu distrib] sources:

...but in functions.sh, the parsing method employed in apt-get.update() is only compatible with the classical syntax such as

...so it fails and doesn't fill the Packages.gz file. The present patch solves this (probably not very elegantly).

probonopd commented 5 months ago

Thanks @csoler. How do you test this?

csoler commented 5 months ago

You just need to do this: pkg2appimage ./retroshare.yml The file retroshare.yml is pasted below. Also I found out that the current functions.sh doesn't actually select the latest package on OBS, probably because packages are not necessarily listed by version number, so it takes the first one in the list. If you use the patch above, you'll get a Retroshare appimage for 0.6.6. In order to force the package version, I implemented a way to specify it in the yml as packages:

csoler commented 5 months ago

note that another way to go would be to fix the automated selection of latest versions of packages from OBS in functions.sh. I opted for specifying the version, as it's probably more handy. Both may be implemented of course. The retroshare.yml is attached below. yml_file.zip

probonopd commented 5 months ago

Thanks @csoler