search

AppImageCommunity / zsync2

Rewrite of https://github.com/AppImage/zsync-curl, using modern C++, providing both a library and standalone tools.
Other
127 stars 23 forks source link

Upgrade or remove vendored zlib? #75

Open lalten opened 3 months ago

lalten commented 3 months ago

The vendored zlib which is used in zsync2 is based on zlib v1.2.1.1, which is now more than 20 years old. Any considerations to either get rid of it or to upgrade to a more recent version?

Here's a patch file I generated by diffing the original zsync's sources with the zlib release they're based on: https://github.com/lalten/zsync/blob/76ba13e254d93d9949feffe3e4171fc49e5be488/c/zlib/zlib_1211.patch

And here is the same patch rebased to the latest zlib, 1.3.1 https://github.com/lalten/zsync/blob/76ba13e254d93d9949feffe3e4171fc49e5be488/c/zlib/zlib_131.patch

probonopd commented 2 months ago

@TheAssassin wdyt?