search

AppImageCommunity / zsync2

Rewrite of https://github.com/AppImage/zsync-curl, using modern C++, providing both a library and standalone tools.
Other
132 stars 25 forks source link

Checks for changes falsely report success #8

Closed TheAssassin closed 6 years ago

TheAssassin commented 6 years ago

In several circumstances, checkForChanges() reports success although the update check should've had failed. Those are most likely caused due to failing/missing checks before calling the library functions from the legacy libzsync, as zsync_sha1() etc. work fine when the struct zsync_state has data set correctly.

Those issues need to be sorted out immediately.

TheAssassin commented 6 years ago

I've added a few more checks and reliability to checkForChanges(). These changes should fix all the bugs I was aware of.

I'll leave the issue open for @probonopd, as he's found the initial issues, to check again whether any of this occurs. Just for your information, I've updated AppImageUpdate, too, so that my fixes are available there, too, with the next build.