Closed marcinsulikowski closed 3 years ago
Thanks for reporting, working on it right now.
Could you please test your bundle using the AppRun and libapprun hooks from this build?
Unzip the file and replace the AppRun in your AppDir by the one inside. Please make sure of selecting the right binary for your arch.
Please test using the binaries from the latest continuous build. Feel free to reopen if the issue persist.
After adding the following to my recipe:
runtime:
version: "continuous"
to use the latest runtime, the created AppImage bundle works as expected. Thank you!
Excellent let's make a release :)
I noticed that
AppRun
executes programs with an invalid list of parameters (it adds a spurious empty argument) whenEXEC_ARGS
in.env
includes any arguments before$@
.I'd like
AppRun
to call an executable with a predefined list of arguments, followed by any extra arguments that user passes toAppRun
itself. An example is the following in.env
:With such an
.env
file, I'd expect./AppRun
to pass the following arguments toexecv
:and
./AppRun --something
to pass the following arguments toexecv
:Unfortunately, whereas the latter works as expected, executing
./AppRun
with no arguments passes the following toexecv
:The extra empty argument causes problems for the application executed by
AppRun
.I can see that
apprun_shell_expand_variables("$APPDIR/opt/app/script.py $@", argv)
returns"(...)/opt/app/script.py "
(i.e., a string with a trailing space). This is then passed toapprun_shell_split_arguments("(...)/opt/app/script.py ")
which in turn returns an array with two elements:"(...)/opt/app/script.py"
and""
.I'm not sure if that makes sense, but I think
apprun_shell_split_arguments
could trim trailing whitespace like it seems to do with leading whitespace.