search

AppImageCrafters / AppRun

AppDir runtime components
MIT License
26 stars 10 forks source link

Add `APPDIR_FORCE_BUNDLE_RUNTIME` #56

Closed TheBrokenRail closed 2 years ago

TheBrokenRail commented 2 years ago

Fixes #53

This is my suggested fix to the above issue, it adds an environmental variable that tells libapprun_hooks.so to assume the target executable is located in the AppImage.

probonopd commented 2 years ago

Please also think about documentation.

Speaking from experience, special edge case workarounds like this end up buried deep in the code and a few years down the road no one knows anymore why they are there...

TheBrokenRail commented 2 years ago

Please also think about documentation.

Speaking from experience, special edge case workarounds like this end up buried deep in the code and a few years down the road no one knows anymore why they are there...

I added documentation to docs/USAGE.md.

azubieta commented 2 years ago

I guess that we were working on the same topic but with different approaches. With this commit https://github.com/AppImageCrafters/AppRun/commit/707c4015543e171067b2b321de5724624b5b74b9 I added support for external modules (plug-ins, add-ons, whatever) which will be treated as part of the original bundle and will use the same runtime.

The use case is to allow applications installing extensions in the user home or somewhere else. It comes with this script to make such modules functional https://gist.github.com/azubieta/202c85f1f5a9e5c6be5cb066fcb2d5e2

I still consider this an experimental feature, that's why it's not documented.

@TheBrokenRail we need better communication could ping my on the appimage irc ?

TheBrokenRail commented 2 years ago

Thanks!