search

AppImageCrafters / appimage-builder

GNU/Linux packaging solution using the AppImage format
MIT License
316 stars 58 forks source link

do not force python 3.8 in CI #285

Closed iTrooz closed 1 year ago

iTrooz commented 1 year ago

Ubuntu 22.04 do not have python 3.8 installed anymore

pip install appimage-builder will also install appimage-builder with other python versions (such as 3.11), so I don't see the need to force python3.8 with github releases specifically

iTrooz commented 1 year ago

It seems like python3.8 is enforced everywhere in the project.

I think the best would be to mark the python version as python3 instead of specifically python3.8. There shouldn't be breaking changes in future 3.x python releases, and this would allow people to use their own version of python easily, if they can't/don't want to install python3.8 (this was my case, and I simply forced the python version to mine)

I'd like to point out again that the package can already be installed on other pythonv ersions with pip

What do you think ?

[Sorry for turning this PR into an issue, I should have checked before opening it]

azubieta commented 1 year ago

The reason why I set a fixed version of python is to be able to debug it properly in case of issues. With python3 only it would be a moving target. It's safe to switch to python 3.11 we just have to update the scripts as you did but keeping the python version fixed.