AppImageCrafters / appimage-builder

GNU/Linux packaging solution using the AppImage format
MIT License
308 stars 58 forks source link

Revert pydpkg #344

Closed damoclark closed 7 months ago

damoclark commented 7 months ago

With the replacement of version comparison with pydpkg, it does not support the use of non-numeric versions. Chiefly, "continous" which is a version tag used throughout the appimage development ecosystem. So any recipe that specifies, for instance the runtime version "continuous" generates an error:

Traceback (most recent call last):
  File "/home/clarkd/appimage/src/appimage-builder/recipes/appimage-builder/../../appimagebuilder/__main__.py", line 63, in <module>
    __main__()
  File "/home/clarkd/appimage/src/appimage-builder/recipes/appimage-builder/../../appimagebuilder/__main__.py", line 50, in __main__
    invoker.execute(commands)
  File "/home/clarkd/appimage/src/appimage-builder/appimagebuilder/invoker.py", line 29, in execute
    command()
  File "/home/clarkd/appimage/src/appimage-builder/appimagebuilder/commands/setup_runtime.py", line 31, in __call__
    apprun_version = version.parse(apprun_version)
  File "/home/clarkd/.local/share/virtualenvs/appimage-builder-WDRM20Lw/lib/python3.10/site-packages/packaging/version.py", line 54, in parse
    return Version(version)
  File "/home/clarkd/.local/share/virtualenvs/appimage-builder-WDRM20Lw/lib/python3.10/site-packages/packaging/version.py", line 200, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: 'continuous'

This PR reverts this change back to the former version code, fixing this regression.