search

AppLayerLabs / bdk-cpp

MIT License
7 stars 12 forks source link

PR for SonarQube fixes #130

Closed Jean-Lessa closed 1 month ago

Jean-Lessa commented 1 month ago

This PR fixes a bunch of SonarQube issues from the development branch. As those issues are always coming and going and reaching 100% clearance might be unfeasible (if not virtually impossible), this might not be the one and only time we do this. For now, I think it's good to take it as is and keep a look out for future issues.

Branch is up-to-date with development up to commit 14584b5, meaning it's synced with the recent merging of #120, including the deprecation of BytesArrView in favor of bytes::View, and a few places that used Utils::appendBytes() now use bytes::join() instead.

bdk-cpp-sonarqube-app[bot] commented 1 month ago

Quality Gate failed Quality Gate failed

Failed conditions
54 New issues

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint