Internal refactor of P2P::Session vs. P2P::ManagerXXX classes - Githubissues

AppLayerLabs / bdk-cpp

MIT License

7 stars 12 forks source link

Internal refactor of P2P::Session vs. P2P::ManagerXXX classes #93

Closed fcecin closed 7 months ago

fcecin commented 8 months ago

This changes the std::weak_ptr<Session> argument in P2P::ManagerXXX APIs to NodeId instead, which induces an additional lookup for the Session object from that NodeId.

I'm also including some changes to the P2P::ManagerBase start / stop.

ghost commented 8 months ago

Quality Gate failed

Failed conditions

25 New issues
12.6% 12.6% Coverage on New Code (required ≥ 80%)
21.4% 21.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint