search

AppLovin / AppLovin-MAX-Cordova

MIT License
10 stars 12 forks source link

fix: use config-file instead of edit-config to add NSAdvertisingAttri… #13

Closed Carlosps closed 2 years ago

Carlosps commented 2 years ago

This issue may happen due to the edit-config tags for adding NSAdvertisingAttributionReportEndpoint on plugin.xml file. Installing "cordova-plugin-applovin-max" for ios Failed to install 'cordova-plugin-applovin-max': TypeError: doc.find is not a function at Object.resolveParent platforms/ios/cordova/node_modules/cordova-common/src/util/xml-helpers.js:131:51

As mentioned here https://stackoverflow.com/questions/47404622/edit-config-for-ios-usage-descriptions-doc-find-is-not-a-function.

A solution for that issue is to use config-file tags instead of edit-config.

thomasmso commented 2 years ago

Hey @Carlosps - I appreciate your PR, we decided to remove the onus of adding this attribute from the plugin and have developers like yourself add it instead. Please feel free to follow our docs here to leverage our iOS15 Global SKAdNetwork Reporting feature: https://dash.applovin.com/documentation/mediation/cordova/getting-started/integration#ios-15-global-skadnetwork-reporting

thomasmso commented 2 years ago

Our latest release 1.0.8 will address that: https://github.com/AppLovin/AppLovin-MAX-Cordova/releases/tag/release_1_0_8

Carlosps commented 2 years ago

Thank you @thomasmso