AppLovin / AppLovin-MAX-SDK-Android

Other
232 stars 104 forks source link

Fix maio SDK Missing in Mediation Debugger #747

Closed tsumuchan closed 1 week ago

tsumuchan commented 2 weeks ago

maio SDK is now v2 with this PR https://github.com/AppLovin/AppLovin-MAX-SDK-Android/pull/704.

At that time, maio's package structure also seems to have changed.

The changes were not reflected in proguard-rules.pro, and the SDK seemed to be missing in the mediation debugger, so I fixed it.

Description by Korbit AI

What change is being made?

Modify the proguard-rules file to ensure complete keepnames coverage of all classes within the jp.maio.sdk.android package and its sub-packages for proper mediation debugger support.

Why are these changes being made?

The change addresses the issue of the maio SDK being missing in the mediation debugger by refining the ProGuard rules to prevent obfuscation of all classes within the specified package, which ensures proper visibility and integration in debugging scenarios.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

korbit-ai[bot] commented 2 weeks ago

Hey there, my name is Korbit. I've joined the team as your AI code reviewer. I'll automatically scan your PRs and raise any issues I find. I can also help you write a PR description. As you work with me, I'll learn about your priorities and codebase and get smarter over time. My goal is to help improve your code quality and save time for the human reviewers on your team. Let's get started!

jplianghu commented 2 weeks ago

Hi @tsumuchan,

Thank you for submitting this PR. We have released Maio Adapter version 2.0.1.2 with the fix you provided!

You can find the commit here: Maio/2.0.1.2