AppLovin / AppLovin-MAX-Unity-Plugin

127 stars 35 forks source link

"Failed to save internal settings" when file is read-only #306

Open pfay-fc opened 1 year ago

pfay-fc commented 1 year ago

MAX Plugin Version

6.0.1

Unity Version

2021.3.11f1

Device/Platform Info

Unity Editor

Current Behavior

Fails to write settings if they are read-only

image

Expected Behavior

Should force write the file by setting it to writeable first

On my own repo I made the following change in Assets/MaxSdk/Scripts/IntegrationManager/Editor/AppLovinInternalSettings.cs to Save()

image

Note that due to how the other settings file Assets/MaxSdk/Resources/AppLovinSettings.asset is managed, it does not have this same issue (Unity forces it to writeable I believe).

Alternatively, there is an argument to be made that applovin should respect the user's read-only flag. As a user I disagree, but if you take this position then the correct fix is to show an explicit error to the user telling them that their settings failed to save, and that they should ensure the file is writeable.

How to Reproduce

Additional Info

No response

github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 30 days with no activity.