AppLovin / AppLovin-MAX-Unity-Plugin

111 stars 31 forks source link

Move MaxSdk to Plugins folder #33

Closed revolt3r closed 2 years ago

revolt3r commented 3 years ago

Would you please consider moving MaxSdk to the Assets/Plugins folder? Or at least allow us to move it manually, right now some paths are hardcoded, so the plugin breaks you move it to a different folder.

Lorenzo45 commented 3 years ago

Thanks for the suggestion! We'll certainly consider moving it if there's enough demand for it. Supporting multiple locations could introduce issues in future updates so we don't believe that's the best path forward.

santoshbagadi commented 2 years ago

@revolt3r we have added support with the ability to move our plugin to a different folder under the Assets directory a while back (plugin version 3.2.0). So, closing this ticket, please let us know if you run into any issues with this.

revolt3r commented 2 years ago

Almost! image

revolt3r commented 2 years ago

You could try AssetDatabase.FindAssets by type instead of path to fix that

santoshbagadi commented 2 years ago

Ah, I think you might need to update the Google adapter. What version of Google adapter are you on?

We don't use path, but we tag our assets with a label (we use the path you see as the tag) and use that to find the asset. The AppLovinSettings.asset should also be tagged with something like al_max_export_path-MaxSdk/Resources/AppLovinSettings.asset. Could you please double check if it is, if not there might be an issue somewhere.

revolt3r commented 2 years ago

You're right, I found the issue -> the slashes are reversed image

santoshbagadi commented 2 years ago

Looks like an issue with path separator being different on Windows. Could you please try replacing

var guids = AssetDatabase.FindAssets("l:al_max_export_path-" + AppLovinSettingsExportPath);

with

var guids = AssetDatabase.FindAssets("l:al_max_export_path-" + AppLovinSettingsExportPath.Replace(Path.AltDirectorySeparatorChar, Path.DirectorySeparatorChar));

in MaxMediationGoogleUtils and see if that fixes it. If so, we can include the change in our next rlease.

revolt3r commented 2 years ago

That fixed it indeed, thanks. Looking forward to the update!

santoshbagadi commented 2 years ago

Great! Thank you for testing the change. We'll include it in the next release.