search

AppMetrics / InfluxDB

App Metrics Extensions for InfluxDB reporting
https://www.app-metrics.io/reporting/reporters/influx-data/
Apache License 2.0
17 stars 13 forks source link

Create db if not existing #20

Closed gickis closed 6 years ago

gickis commented 6 years ago

Would be nice that app.metrics influxdb reporter will create database if it was not created

alhardy commented 6 years ago

I think in many cases an application wouldn't have such permission. For those that decide it's OK, it could be done just as easily outside App Metrics on app startup. Thoughts?

gickis commented 6 years ago

Agree with you, in most cases there is not root rights to influxdb instance. But on other hand, there is so easy to implement it, so maybe in future would be nice to have this feature as useful addition.

alhardy commented 6 years ago

I'll think about it again once a stable 2.0 release goes out. I guess I can think about it like getting started with EF which creates db tables on startup to make the dev experience a little better ;)

RouR commented 6 years ago

Please add this feature. Heapster and Telegraf do it. Same behavior is expected. It does not need any additional permissions (InfluxDB does not have any public endpoints, and used in local net only).

alhardy commented 6 years ago

@RouR Already done, please see the commit associated with this issue, but note it is in "Ready for Release", meaning packages have not yet been released to nuget.

Also re Influxdb administration, you should probably review https://docs.influxdata.com/influxdb/v1.4/query_language/authentication_and_authorization/

Not having "public endpoints" would depend you your setup of course.