Used Polly as execution engine for HTTP calls

AppMetrics / InfluxDB

App Metrics Extensions for InfluxDB reporting

https://www.app-metrics.io/reporting/reporters/influx-data/

Apache License 2.0

17 stars 13 forks source link

Used Polly as execution engine for HTTP calls #28

Open gickis opened 6 years ago

gickis commented 6 years ago

The issue or feature being addressed

issue #27

Details on the issue fix or feature implementation

Used Polly as execution engine for HTTP calls

Confirm the following

[x] I have ensured that I have merged the latest changes from the dev branch
[x] I have successfully run a local build
[x] I have included unit tests for the issue/feature
[x] I have included the github issue number in my commits

alhardy commented 6 years ago

As mentioned here not sure I want to take the dependency.

Does the benefit outweigh taking on the dependency i.e. worth users of App Metrics dealing with potential version conflicts in their apps?

What are the benefits in using Polly versus a very simple implementation?

gickis commented 6 years ago

I know that Polly it's additional dependency to project, but on other hand using 3rd party frameworks will give us ability to concentrate on business logic instead of infrastructure things like "retry with backoff".

I even think that adding Polly will show to developers that App.Metrics is "Powered by Polly" and as result it could be positive indicator to App.Metrics project!