Fixes crash which sometimes happens in PieChartRow - Githubissues

AppPear / ChartView

ChartView made in SwiftUI

MIT License

5.26k stars 645 forks source link

Fixes crash which sometimes happens in PieChartRow #266

Closed harryblam closed 9 months ago

harryblam commented 9 months ago

Description

We experience random crashes sometimes when the PieChartRow data is mutated often (see below screenshot).

Motivation and Context

This code makes the race condition that was causing the crash not possible.

Screenshots (if appropriate):

Screenshot 2023-09-29 at 11 31 04

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (Updating Documentation, CI automation, etc..)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.