search

AppPear / ChartView

ChartView made in SwiftUI
MIT License
5.26k stars 646 forks source link

Custom dropshadow and size #7

Closed Seitenwerk closed 4 years ago

Seitenwerk commented 4 years ago

Hey, first: The charts look awesome!

But I wonder if it is possible to remove the drop shadow and make the chart fullscreen? At least being able to make a custom size for the line chart would be very nice.

While I like the idea of those small cards, the charts look and behave too good not to use them as full blown charts inside an app.

AppPear commented 4 years ago

Hi, thanks! I haven't published a full screen linechart view yet, tho I have this prototype, check out: https://twitter.com/sandris96/status/1168962872111771648?s=20 I can share it if you wish

Seitenwerk commented 4 years ago

That’s amazing! I actually started trying to create a similar variant based on your work but it seems like you were already working on exactly what I had in mind. :)

Still learning how to work with those touch events in SwiftUI. If there is something you can share, I would be happy to get inspiration from that.

Am 04.10.2019 um 11:24 schrieb Andras Samu notifications@github.com:

 Hi, thanks! I haven't published a full screen linechart view yet, tho I have this prototype, check out: https://twitter.com/sandris96/status/1168962872111771648?s=20 I can share it if you wish

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

bingimar commented 4 years ago

yes, fantastic charts!!

I also would like to remove the drop shadow.

wildfang commented 4 years ago

Any news on this? The graphs look fantastic but the current form (shadow + size) is not what I need...

theramzay commented 4 years ago

@AppPear awesome chars! Any news about full screen mode ?

AppPear commented 4 years ago

Hi, added full screen line chart (LineView) also added the option to turn off drop shadow check out the readme. Will add custom drop shadow size soon. Stay tuned!

wildfang commented 4 years ago

After updating to 1.4.0, I can not compile anymore.. Error:

/Library/Developer/Xcode/DerivedData/TestChartViews-clbxmdavqalfeieqqijfuouqgezb/SourcePackages/checkouts/ChartView/Sources/SwiftUICharts/LineChart/Legend.swift:32:33: Reference to property 'colorScheme' in closure requires explicit 'self.' to make capture semantics explicit

theramzay commented 4 years ago

@wildfang same for me, I've just added self. for fast fix, but got another problem from my issue.

AppPear commented 4 years ago

Thanks I’m going to look into that

AppPear commented 4 years ago

Should be fixed by 1.4.1