AppScale / appscale-tools

A set of command-line tools that can be used to interact with AppScale.
Other
51 stars 49 forks source link

Do not use regex to parse appengine-web.xml #660

Closed cdonati closed 6 years ago

cdonati commented 6 years ago

Previously, a commented out application tag could be chosen as the project ID.

whoarethebritons commented 6 years ago

So will this prevent us from grabbing any commented out XML?

obino commented 6 years ago

@whoarethebritons the unit tests does exactly that check :)

cdonati commented 6 years ago

https://ocd.appscale.com:8080/job/Daily%20Build/4097/