search

AppScale / appscale-tools

A set of command-line tools that can be used to interact with AppScale.
Other
51 stars 49 forks source link

Use managed availability set for adding VMs created with managed disks #721

Closed tmarballi closed 5 years ago

tmarballi commented 5 years ago

The type of availability set currently in master does not work with VMs created with managed disks. So in this PR, if the VMs are created using the marketplace public image then a managed availability set gets created and if not the regular one which works with VHD images.

tmarballi commented 5 years ago

https://ocd.appscale.com:8080/job/Daily%20Build/5486/

cdonati commented 5 years ago

If I understand correctly, this change makes the assumption that VMs based on a marketplace image must use managed disks. It also makes the assumption that VMs that aren't based on a marketplace image will never use managed disks. Will those assumptions always be true? What do we do in a situation where a load balancer needs to be created with a managed disk, but we don't want to use a marketplace image?

tmarballi commented 5 years ago

From what I know of managed disks, the only way to currently use them in our Azure agent is to use it with a marketplace image. Managed disks can only be used with a publisher image and not with our custom AppScale vhd image. And @whoarethebritons correct me if I am wrong, but that's the only way we can attach disks currently for any Azure deployment right?

whoarethebritons commented 5 years ago

@tmarballi yes.

@cdonati using a marketplace image makes the underlying os disk a managed disk and additional managed disks can only be added to VMs that have managed os disks. As far as I know using a marketplace image is the only way to make the underlying os disk a managed disk. VMs started with vhds will have unmanaged os disks and are unable to have managed disks attached to them.