AppStateESS / InternshipInventory

Web app for tracking and approving student internships.
http://appstateess.github.io/InternshipInventory/
GNU General Public License v3.0
10 stars 22 forks source link

Display Instructor after Removed From Dept #356

Closed caldwellc1 closed 6 years ago

caldwellc1 commented 7 years ago

Ref #338 I made the data for the faculty supervisor appear even if they are removed from the department. I split the selectFaculty function into itself and updateFaculty so I could use it with my new call for just a faculty member with no department list. I forgot I went into SaveInternship.php and changed the indentions to make it more readable. But looking at the code listed below it still looks indented funny.

jlbooker commented 7 years ago

Causes a 500 error request to the server when there are no faculty members in the department. Probably caused by if statement checking length of faculty array. Need to investigate further before this can be merged.