AppStateESS / homestead

A web-application for managing on-campus student housing.
GNU General Public License v3.0
4 stars 12 forks source link

Escape key code output #1147

Closed jlbooker closed 6 years ago

jlbooker commented 7 years ago

In the check-out interface's javascript, we need to escape the text fields before echoing them.

For example, if a user begins the key code field with a ' (single quote) character, then the key code is output as:

var previous_key_code = ''BC3N083A-1';

Which causes a syntax error (and likely a xss-scripting vulnerability).

This is probably true of all the text fields on that page.

jlbooker commented 6 years ago

:+1: