search

AppStateESS / homestead

A web-application for managing on-campus student housing.
GNU General Public License v3.0
4 stars 12 forks source link

Fixed the issues with the timepicker (jQuery) not working properly #1193

Open tylercraig9332 opened 6 years ago

tylercraig9332 commented 6 years ago

So, JQuery removed the $.browser method in 1.9 which I added onto to the timepicker file that used it. I'm not sure if that's the best idea; I feel that it would have been better to make a js file/class that would return the browser, so if other files use it we can reuse the code.

Also, I think we talked about using a Bootstrap modal instead of a JQuery one. I can work on this if needed.

jlbooker commented 6 years ago

Yes, we definitely want to update to a Bootstrap modal dialog instead of the jQuery UI dialog.

It's probably time to move to a more updated timepicker then, if this one hasn't kept up with changes in jQuery. I tried to find a project for the one we're using, to see if they have an updated version, but it doesn't appear to be maintained anymore. Perhaps try this project instead: http://timepicker.co/ We should include that project via their npm package, instead of including the code directly in our project (and therefore remove the javascript/timePicker/ directory).