search

AppStateESS / homestead

A web-application for managing on-campus student housing.
GNU General Public License v3.0
4 stars 12 forks source link

Empty meal plan bug #1202

Open eberhardtm opened 5 years ago

eberhardtm commented 5 years ago

Putting this in here in case something crazy happens and somehow hms doesn't go away.

When selecting meal plan for lottery winners and their invited roommates sometimes the meal plan in the request is lost. To complicate things more there is a vestigial request variable. Some request have duplicate variables meal_plan and mealPlan. Sometimes meal_plan is set and sometimes mealPlan is set. And sometimes neither are set. This seams to be more student dependent then command context dependent. Could this be related to the students application? Its hard to say because the code in the lottery confirmation over writes the data in the application table so its a chicken or an egg problem. Is the meal plan in the application blank or is the lottery logic setting it blank? Hopefully I will never have to debug this...

jlbooker commented 5 years ago

Heh, sorry about that...

My guess is that is has to do with the various "types" of application. Freshmen, reapplication, and learning community self-select were all slightly different, and this sounds like something that would come out of that. It needed to be refactored into something more consistent...