AppThreat / atom

Atom is a novel intermediate representation for applications and a standalone tool that is powered by chen.
https://appthreat.com
Apache License 2.0
43 stars 2 forks source link

Support for filtering the slices #4

Closed prabhu closed 1 year ago

prabhu commented 1 year ago

We need a way of customizing the slicing operation to limit the data that gets written to the slices json.

Usages slices

DataFlow slices

Common

DavidBakerEffendi commented 1 year ago

I've ticked what this PR would address: https://github.com/joernio/joern/pull/2928

Filtering on sources is a bit tricky, since the data-flow slicing is backward slicing, i.e. starts from a sink and goes backwards a set number of times. Depending on how far back it goes, it may never reach a source, so we can't always assume the last node in the backward slice is the source.

prabhu commented 1 year ago

@DavidBakerEffendi, Could we consider forward slicing (beginning from a source) as a future enhancement? We might encounter applications with only a few sources so that performance gains could be possible.

prabhu commented 1 year ago

This ticket could be considered as done since we have more than enough filters for v1.0.0 release.