AppaYY / fitnesse-bootstrap-plus-theme

An extended theme for FitNesse that increases it's usability and functionality
Apache License 2.0
2 stars 0 forks source link

Hardcoded extra header is a surprise #32

Closed lennyg1 closed 4 years ago

lennyg1 commented 4 years ago

Currently I rebuild my header based on my target audience and environment. This includes adding or removing buttons and other elements I might want to use. Sometimes just a line, sometimes a separate menu with specific functionality. Somethings something entirely different that integrates with my SUT.

To create this, I use documentation within the FitNesse UserGuide, like; http://fitnesse.org/FitNesse.FullReferenceGuide.UserGuide.WritingAcceptanceTests.SpecialPages http://fitnesse.org/FitNesse.FullReferenceGuide.UserGuide.FitNesseWiki.MarkupLanguageReference.MarkupStyle

This means that a 2nd major header that's now by default in bootstrap-plus might have unintended side-effects when I also have a larger pageheader for whatever reason. Considering this is base functionality of FitNesse, it's not unlikely that some other user might be using the header in unexpected ways as well.

I'm actually using similar buttons for an example;

image

Lizzze commented 4 years ago

We have added the issues to the backlog of our Trello board

https://trello.com/c/Wc4PwiP7/208-us-60-hard-gecodeerde-header-weghalen

maartenjanvangool commented 4 years ago

I think you were not the only one complaining, I think this is changed in https://github.com/praegus/toolchain-fitnesse-plugin/releases/tag/toolchain-fitnesse-plugin-2.0.1

Lizzze commented 4 years ago

This issue is fixed.