Apparence-io / CamerAwesome

📸 Embedding a camera experience within your own app shouldn't be that hard. A flutter plugin to integrate awesome Android / iOS camera experience.
https://ApparenceKit.dev
MIT License
976 stars 256 forks source link

Add optional for storage permission on Android #113

Closed nghiashiyi closed 1 year ago

nghiashiyi commented 3 years ago

Description

Sometimes, developers don't need require WRITE STORAGE in android in their purpose. So it will a bit annoying to user when the storage permission was asked, so I hope it should have an option to ignore STORAGE permission

Checklist

Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

Breaking Change

If your feature break something, please detail it

ghost commented 3 years ago

Thanks for submitting this PR, we will review it asap :)

g-apparence commented 2 years ago

Hard to maintain

if (permissions.isEmpty()) {
        permissions.add(CAMERA);
        if (!ignoreExternalStorage) {
            permissions.add(WRITE_EXTERNAL_STORAGE);
        }
    }

I'll had some more if you want work on this. Sorry for the delay.