Closed migalv closed 1 year ago
Yes you're right. Added the enhancement label
We tested on latest iPhone 14 & on 3 Android devices (2 new, 1 old).
Only the old Android device (Huawei) did not perform a flip on the Selfie, all others do a Flip. So we think it's a manufacturer choice but in the major case it seems flip the selfie image is the best way to display a selfie image.
On the native camera app of my Xiaomi Mi 9T, the picture taken is mirrored like expected from @migalv. After searching in the settings of the app, I found an option to set front camera pictures to be mirrored or not. Not sure if it was enabled by default or if I've set it manually. Overall, it seems to be an user/manufacturer choice, we should probably give an option to control it rather than expect a behaviour to be the right one for every one
I agree with @apalala-dev. This seems to be a users/manufacturer's choice. So if you allow the developer to choose the expected behavior for their app it would be a really good improvement.
Yeah of course, we can expose an option to flip the selfie or not !
On the Android side @apalala-dev did you flip the image manually ? I'm just worried about the flip was done on the cameraX part and AVCapture side ?
I don't think there is any handmade flip made on the Android part. I am not sure if it can be done directly by CameraX (with a setting or something like that). The more problematic on the Android side is that I don't know if the image is flipped or not which means I don't know if the image needs to be flipped or not 😕 I hope that CameraX is consistent and is always flipped (or not flipped)...
It's easier than expected on Android:
You might have something similar on the iOS part @istornz ?
Apparently this is a feature quite demanded on the official plugin: https://github.com/flutter/flutter/issues/27650
We might get an other reason to implement it! 👀
@apalala-dev Yeah very easy on the iOS side too, we just need to remove the first condition 👍 It's a good idea to implement it !
Apparently this is a feature quite demanded on the official plugin: flutter/flutter#27650
We might get an other reason to implement it! 👀
That's exactly right @apalala-dev
You guys are amazing! Let's go
Hi @migalv, I created a new PR to implement this feature on Dart & iOS sides #278. @apalala-dev will implement the Android part asap 👍
Steps to Reproduce
Expected results
In my opinion, when taking pictures in selfie mode they should always be mirrored as this is the expected behavior by 99% of users.
Here is an example from Instagram:
Instagram
Actual results
The image is flipped and generates a strange sensation.
Example from CamerAwesome example code:
CamerAwesome
About your device
Flutter Doctor