🐛 inverted preview fix

Apparence-io / CamerAwesome

📸 Embedding a camera experience within your own app shouldn't be that hard. A flutter plugin to integrate awesome Android / iOS camera experience.

https://ApparenceKit.dev

MIT License

906 stars 199 forks source link

🐛 inverted preview fix #432

Closed g-apparence closed 4 months ago

g-apparence commented 5 months ago

Description

tablet devices inverts preview

So we have to rotate the preview and change the scale ratio according to this to.

InspectlyMads commented 5 months ago

Today, I conducted testing, and unfortunately, both Android and iOS still exhibit incorrect orientation. Additionally, it appears that the view is now stretched. Tomorrow, I plan to review the code to identify and address the underlying issue.

g-apparence commented 5 months ago

If that's streched I think that this is because the preview size is wrong on your tablet. Could you tell me which device you used?

InspectlyMads commented 5 months ago

If that's streched I think that this is because the preview size is wrong on your tablet. Could you tell me which device you used?

Ios:

Tested on physical iPad 9. generation with the pr changes I have observed that rotations is still wrong.
Landscape-left is now upside
Landscape-right is correct.
Portait-up is now sideways where as portrait was correct before the pullrequest.
Portrait-down is upside down

Android:

Tested on emulated android tablet with the pr changes I can no longer reproduce the issue on my android emulator tablet. The orientation now seem to behave like on phones.

Furthermore I have added a review explaining the issues at hand and a proposal for a solution

InspectlyMads commented 4 months ago

@g-apparence Do you need anything else from me here? :)

g-apparence commented 4 months ago

I have to test this on all my phones then I'll merge it. Sorry I'm currently releasing an app so I don't have that much time. (it also uses CamerAwesome)

g-apparence commented 4 months ago

closing as #448