search

Apparence-io / CamerAwesome

📸 Embedding a camera experience within your own app shouldn't be that hard. A flutter plugin to integrate awesome Android / iOS camera experience.
https://ApparenceKit.dev
MIT License
906 stars 199 forks source link

Missing release for fix of missing onMediaCapure field #480

Open olenirwing opened 1 month ago

olenirwing commented 1 month ago

Hey @g-apparence, i think you mistakenly forgot to include your last commit in the 2.0.1, which means that onMediaCapture field is still missing. I'm assuming because the commit came just 30 minutes after you created the release. Please correct me if I'm wrong :)

nickolasdeluca commented 3 weeks ago

Hey @olenirwing, this event you mentioned, was it used to return the picture when the user took the picture? I was wondering why do we have to tap the media button to be able to get the picture just taken.

I understand having to do it if you have your widget set to take multiple pictures, but when it's set to single, it should return the picture right after the user takes the photo.

Am I right to assume this?

ryanhanks-bestow commented 5 days ago

@nickolasdeluca @g-apparence, @olenirwing is correct in calling out the mismatch between the version published to pub and what's tagged as 2.0.1 here in this repo.

Can we get a revision bump pushed to correct for this? This was also noticed by @Harpreetcompetent in https://github.com/Apparence-io/CamerAwesome/issues/474

Screenshot 2024-06-25 at 10 53 15 PM Screenshot 2024-06-25 at 10 54 19 PM
ryanhanks-bestow commented 5 days ago

Correction, there's no 2.0.1 tag on this repo, however the version in pubspec and published to pub are both 2.0.1

ryanhanks-bestow commented 1 day ago

@g-apparence can we get a release that includes onMediaCaptureEvent on CameraAwesomeBuilder.awesome?

I started building upon it for lack of understanding of an equivalent approach, but, as mentioned above, onMediaCaptureEvent didn't make it into the 2.0.1 that shipped to pub.dev.

Let me know if there's anything I can do, or if there's someone else I can bring into this convo that can help us get this pushed out.

Thanks!

xcc3641 commented 1 day ago

@g-apparence can we get a release that includes onMediaCaptureEvent on CameraAwesomeBuilder.awesome?

I started building upon it for lack of understanding of an equivalent approach, but, as mentioned above, onMediaCaptureEvent didn't make it into the 2.0.1 that shipped to pub.dev.

Let me know if there's anything I can do, or if there's someone else I can bring into this convo that can help us get this pushed out.

Thanks!

I just use this to fix it for interim processing.

  camerawesome:
    git:
      url: git@github.com:Apparence-io/CamerAwesome.git
      ref: master