Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK

https://www.braze.com

Other

165 stars 142 forks source link

ABKModalViewController doesn't fullScreen #225

Closed ghost closed 4 years ago

ghost commented 4 years ago

[x] I have checked Braze's documentation and am still experiencing the issue.

Report

Describe your environment.

Info	Value
Platform Name	ios
Platform Version	12 - 13
SDK Version	3.21.3
Integration Method	cocoapods
Xcode Version	Xcode 11.3
Repro rate	all the time (100%)

What did you do?

In an inAppMessage popup which then has to open a full screen web page

What did you expect to happen?

the web page must be full screen

What happened instead?

the web page is not full screen and the navigationBar is missing which is transparent

Steps to reproduce

Create an InAppMessage with a button whose action is Redirect to Web Url.
Write a url
Flag the Open WebView inside App
Sent campaign
It opens a webView not full screen and with the transparent navigationBar.

ghost commented 4 years ago

This is the webpage in ABKModalViewController

hokstuff commented 4 years ago

Hi @AdrianaCarelli,

We are unable to reproduce this issue. Are you doing any customizations for our in-app messages? Is this happening for all types of in-app messages or just for modal ones? Also, if you can send over a screenshot of your view hierarchy, that would be helpful as well.

If you don't want to post this directly on Github, you can contact support@braze.com and we can continue the conversation on that thread.

Thanks, Daniel

bstillitano commented 4 years ago

This is due to the new modal style presentation in iOS 13. Compiling with the latest version of Xcode reliably reproduces this.

hokstuff commented 4 years ago

Are you doing any customization for your UI? On SDK version 3.21.3, iOS 13.3.1, and using the latest Xcode 11.4, I am seeing the default gray background behind the "Done" button, as shown in this image when opening a web url inside the app. https://i.stack.imgur.com/BPuWH.png

hokstuff commented 4 years ago

Are you still experiencing this issue @AdrianaCarelli @bstillitano?

ghost commented 4 years ago

@hokstuff Yes, I was unable to solve it.

hokstuff commented 4 years ago

@AdrianaCarelli Can you send any customization that you may be doing for the UI? Also, can you send a screenshot of your view hierarchy so we can investigate the issue you're experiencing?

hokstuff commented 4 years ago

I'm closing out this issue due to inactivity. Please contact our Support team with more details if you want us to investigate further - thanks!