search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

.strings files are not accessible (via Carthage) #231

Closed anaglik closed 4 years ago

anaglik commented 4 years ago

[*] I have checked Braze's documentation and am still experiencing the issue.

Report

When SDK is integrated via Carthage, localization files are not accessible. (Although Appboy.bundle is properly located inside framework). When e.g error occurs, string key is displayed instead of translated text. (e.g APPBOY.NO-CONNECTION.MESSAGE). In documentation you mentioned "For your convenience, our CocoaPod integrates the .strings files for the aforementioned languages". How to integrate .strings files when using Carthage? What is preferred way to do that?

Environment

Info Value
Platform Name ios
Platform Version all
SDK Version 3.21.3
Integration Method Carthage
Xcode Version Xcode 11.4
Repro rate all the time (100%)
Bucimis commented 4 years ago

@anaglik thanks for bringing this to our attention. Are you accessing our string values programmatically for display in your own view controller or are the string values in the Appboy UI (for example, ABKContentCardsTableViewController) displaying incorrectly?

anaglik commented 4 years ago

@Bucimis Thanks for quick response. Missing strings are coming from Appboy UI. (in my case In-App Message feature)

screenshot-appboy
Bucimis commented 4 years ago

@anaglik thanks - for context, which language did you use to test?

anaglik commented 4 years ago

Screenshot above is from simulator running English. I was also testing other languages (e.g Polish) on real device and it works the same way.

chshapiro commented 4 years ago

Hey @anaglik,

We were unable to repro the issue you are reporting. Can you send us a sample app that repros the issues? If you're not comfortable posting it here, you can email it to support@braze.com.

Thanks!

anaglik commented 4 years ago

Hey @chshapiro,

Issue was caused by "Show non-localized strings" feature turned on for debug scheme. When it is turned off all work as expected. Let's close that ticket now. Once again, thanks for quick responses.