Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
168 stars 141 forks source link

Use CocoaPod's resource_bundle #241

Closed k0nserv closed 3 years ago

k0nserv commented 4 years ago

Report

Braze causes apps that integrate it to look like they support all localizations that Braze supports because of s.resources and the copy bundle resource step. Per https://github.com/CocoaPods/CocoaPods/issues/1930 the issue should solve itself if the pod uses s.resource_bundle instead of s.resources.

Describe your environment.

Info Value
Platform Name ios
Platform Version All
SDK Version All
Integration Method cocoapods
Xcode Version All
Repro rate 100%

What did you do?

Integrate Braze through CocoaPods

What did you expect to happen?

Braze not to modify the langauges listed as supported by my app.

What happened instead?

Braze's localisation support causes my app to seem like it supports languages it doesn't support.

Steps to reproduce

Simulator Screen Shot - iPhone 11 Pro Max - 2020-07-15 at 10 59 42

Project that demonstrates the issue

BrazeLocalizationIssue.zip

hokstuff commented 4 years ago

Hi @k0nserv,

Thanks for the detailed steps to repro and a suggestion for the fix! We are investigating and will let you know when the fix is ready.

lucas-mancini commented 4 years ago

Any workarounds for this? I have the same issue.

hokstuff commented 3 years ago

Hi @lucas-mancini,

Apologies for the late reply! We are verifying a fix for this issue, which should be ready relatively soon. We will keep you updated for when it gets released.

Thanks for your patience!

hokstuff commented 3 years ago

Hi @k0nserv and @lucas-mancini,

We have released SDK version 3.31.1 which fixes this issue. Please let us know if you are still experiencing problems - thanks!

k0nserv commented 3 years ago

Excellent, thanks for addressing it 🎉

lucas-mancini commented 3 years ago

Thank you so much!!