search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Support for iOS 14 release version through carthage #248

Closed bharathnagarajrao closed 3 years ago

bharathnagarajrao commented 4 years ago

Report

Describe your environment.

Info Value
Platform Name ios
Platform Version 14.0
SDK Version v3.27
Integration Method carthage
Xcode Version Xcode 12 beta 4
Repro rate all-time

What did you do?

As per this integration document, for iOS 14 compatibility, we would like to update appboy SDK to beta version, ie 3.27 https://www.braze.com/docs/developer_guide/platform_integration_guides/ios/ios_14/#upgrade-summary

What did you expect to happen?

As per this integration document, for iOS 14 compatibility, we would like to update appboy SDK to beta version, ie 3.27 https://www.braze.com/docs/developer_guide/platform_integration_guides/ios/ios_14/#upgrade-summary

What happened instead?

Since we use carthage, v3.27* is not available here https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk_core.json

Steps to reproduce

Paste this link in a browser & observe https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk_core.json

If this is not the right link to add iOS 14 related versions through carthage, could you please share the right link ?

Code Snippet

-

Are you doing any feature customizations that may relate to the issue? Can you share the code snippet?

-

Project that demonstrates the issue

-

chshapiro commented 4 years ago

Hey @bharathnagarajrao,

Unfortunately, due to Carthage restrictions, we are unable to release full Carthage support for our beta versions of the SDK. However, we have attached the frameworks to the release page and you can integrate those into your app.

Please let us know if you have any further questions. Thank you!

bharathnagarajrao commented 4 years ago

@chshapiro Thanks for your response. There are other frameworks which provide beta versions (8.0.0-beta1) through carthage. Could we explore that option ? Also, may I know if we can expect carthage support once Xcode 12 GM version is released ?

chshapiro commented 4 years ago

Hey @bharathnagarajrao,

According to the Carthage docs, Tags without any version number, or with any characters following the version number (e.g., 1.2-alpha-1) are currently unsupported, and will be ignored. For the future, we can try to investigate what other frameworks are doing to make it work.

We will release version 3.27.0 of the SDK within a few days of the Xcode 12 GM release, and that will include full Carthage support.

bharathnagarajrao commented 4 years ago

Thanks @chshapiro. Appreciate your quick response

chshapiro commented 3 years ago

Hey @bharathnagarajrao,

Last week we released version 3.27.0 of the SDK which included Carthage support for iOS 14. Feel free to reopen if you run into any further issues. Thanks!

bharathnagarajrao commented 3 years ago

Thanks @chshapiro. We were able to update 3.27.0 through Carthage