Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Update SDWEBImage to last release to support iOS 14 #249

Closed IsmailSafadi closed 3 years ago

IsmailSafadi commented 3 years ago

We have a conflict in our project we have a last version of SDWebImage 5.9.1 and it supported iOS 14 and resolved some problems with new iOS , and the last version 3.27.0 it supported old version , can you update SDwebimage to last version

Screenshot 2020-09-17 at 15 21 14
chshapiro commented 3 years ago

Hey @IsmailSafadi,

We're going to update this in an upcoming release. In the meantime, can you pin the SDWebImage version in your app to ~>5.8 in order to fix the conflict?

Thanks!

IsmailSafadi commented 3 years ago

no I can not because we support gif image and it has problems in ~>5.8 and it fixed in 5.9 and Animated image it is working correctly in 5.9.1 , Note : it has no conflict with version 3.26.1 but as you know we have a problems iOS 14 in version 3.26.1 and it resolved it in 3.27.0

Bucimis commented 3 years ago

@IsmailSafadi thanks for the feedback. We have a fix but would need time to validate it and run through our QA/release process - would early next week work in terms of timeline?

romandrahan commented 3 years ago

The same for us. We're using latest SDWebImage 5.9.1 with fixes we need which conflicts with your 5.8.2 version.

IsmailSafadi commented 3 years ago

@IsmailSafadi thanks for the feedback. We have a fix but would need time to validate it and run through our QA/release process - would early next week work in terms of timeline?

Thanks , We wait you

hokstuff commented 3 years ago

Hi @IsmailSafadi @romandragan,

We just released iOS SDK 3.28.0 which will be compatible with SDKWebImage version 5.9.x. Thanks!