search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Crash when clicking on a newsfeed card without clicking behaviour #251

Closed carlosnaguilera closed 3 years ago

carlosnaguilera commented 3 years ago

Report

Describe your environment.

Info Value
Platform Name iOS
Platform Version 13.7 and 14.00
SDK Version 3.22 and higher
Integration Method cocoapods
Xcode Version Xcode 11.5 and 12.0
Repro rate always

What did you do?

Clicked on a news from newsfeed without clicking behaviour

What did you expect to happen?

App should do nothing, remain in newsfeed and keep working

What happened instead?

App crashed

Steps to reproduce

-Create a news in news feed without clicking behaviour -Try to open that news

Comments

This is a big issue for us as now we are forced to update to 3.27 in order to be able to release our iOS 14 version

carlosnaguilera commented 3 years ago

Looking into the code I think it is happening because you have replaced[ABKUIURLUtils openURLWithSystem:cardURL] with [ABKUIURLUtils openURLWithSystem:cardURL fromChannel:ABKNewsFeedChannel]. And this new method doesn't handle properly nil url.

chshapiro commented 3 years ago

Hey @carlosnaguilera,

Are you doing any customization on the news feed and are you implementing the ABKURLDelegate?

Thanks!

carlosnaguilera commented 3 years ago

Braze Support "official" Case #: 00053653

carlosnaguilera commented 3 years ago

Hi @chshapiro,

No customisation of news feed Yes, we implement ABKURLDelegate. But I don't see it in stack trace of the crashes

chshapiro commented 3 years ago

Hey @carlosnaguilera can you send us the stack trace? If you don't want to add it to this public issue, you can email it to support@braze.com. It would also be helpful to see your implementation of ABKURLDelegate. Thanks!

carlosnaguilera commented 3 years ago

I've forwarded the information you asked and some more to support@braze.com. Thank you!

chshapiro commented 3 years ago

@carlosnaguilera, thank you for sending that information over. We have identified the issue and will be releasing a fix early next week.

hokstuff commented 3 years ago

Hi @carlosnaguilera,

We've released iOS SDK 3.28.0 which should fix the issue you were seeing. Please reopen if you have any further issues - thank you!