search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Remove or replace `user_target_xcconfig` settings #259

Closed leberwurstsaft closed 2 years ago

leberwurstsaft commented 3 years ago

It's come to our attention that there are now many pod spec authors, including you, that added this user_target_xcconfig setting to their pod specs.

However, doing so causes some trouble when Cocoapods installs multiple pods that use this setting but have differing values. On pod install warnings like this will be emitted:

[!] Can't merge user_target_xcconfig for pod targets: [... list of pods ...]. Singular build setting EXCLUDED_ARCHS[sdk=<...>] has different values.

The podspec syntax reference says this attribute is "not recommended" and discourages its use.

https://guides.cocoapods.org/syntax/podspec.html#user_target_xcconfig

Bucimis commented 3 years ago

Hi @leberwurstsaft,

Thanks for submitting this pull request and we definitely hear you on this being a suboptimal solution. We're working on an update to our Pod that will make it use XCFrameworks instead of Frameworks, which will ultimately make the user_target_xcconfig workaround unnecessary. I can't give an exact timeframe because of an external dependency (Cocoapods 1.10) but I would expect this to land over the coming few months.

hokstuff commented 2 years ago

Hi @leberwurstsaft,

I'm closing out this issue because it has been addressed when we transitioned to use XCFrameworks starting with version 4.0.0. You can find the most recent versions of our SDK here. Thanks!