search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Preventing stackoverflow crashes #265

Closed rodrigoands closed 3 years ago

rodrigoands commented 3 years ago

We were experiencing some stackoverflow crashes since the version 3.29.1 more specifically when some users were receiving in app messages. We tested these changes on our app and the in app messages are working fine.

I attached to this pull request the evidence of stackoverflow

2020-12-1319-25-38.3202-0300-04ce28e3ab9656cbb9bab6edb2724a01096f7750.txt

lowip commented 3 years ago

Hi @randradedasilva, thanks for this PR!

We have identified the issue and are reviewing an internal fix which should be part of the next release.

Your proposed changes disable some key features (namely SceneDelegate support and status bar style inheritance for complex view hierarchies).

Your application might not requires those features though we recommend you to wait for the next release if possible (instead of releasing on the app store with your fork).

hokstuff commented 3 years ago

Hi @randradedasilva,

We have released a fix in version 3.30.0 that addresses this issue. Please update to that version or one of the newer ones and let us know if you have further problems.

Thanks!