Update Modal Headline Label to have accessibility trait be Header

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK

https://www.braze.com

Other

165 stars 142 forks source link

Update Modal Headline Label to have accessibility trait be Header #272

Closed pang0018 closed 3 years ago

pang0018 commented 3 years ago

We are have Accessibility audits of our app and one issue is that the Headline label in the Appboy modals for iOS are not marked as "Header" for accessibility purposes. This PR marks it as such to meet with the requirement of the audit and to be compliant.

davidbielik commented 3 years ago

Hi @pang0018 thanks for submitting this PR! While we can't merge this PR since our development is done in another private repo, we will work to incorporate this into a future release.

Thanks again!

pang0018 commented 3 years ago

Fair enough @davidbielik. Thank you for your response.

hokstuff commented 3 years ago

Hi @pang0018,

We have added your suggested change into our recent 3.32.0 release. Please let us know if you are still experiencing this issue - thanks!