search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

IAM Modal Background Does Not Dismiss #278

Closed lustig-bakkt closed 3 years ago

lustig-bakkt commented 3 years ago

Report

Sending an IAM Modal message is functional, but does not dismiss properly. If relevant, we have attached a deeplink to Button 1. FWIW this is a react-native integration and we are using version 1.26.0 with iOS SDK version 3.31.2.

GIF:

2523 fix ios deeplinking iam working, braze modal broken

Relevant Information

Pods

  - Appboy-iOS-SDK (3.31.2):
    - Appboy-iOS-SDK/UI (= 3.31.2)
  - Appboy-iOS-SDK/ContentCards (3.31.2):
    - Appboy-iOS-SDK/Core
    - SDWebImage (< 6, >= 5.8.2)
  - Appboy-iOS-SDK/Core (3.31.2)
  - Appboy-iOS-SDK/InAppMessage (3.31.2):
    - Appboy-iOS-SDK/Core
    - SDWebImage (< 6, >= 5.8.2)
  - Appboy-iOS-SDK/NewsFeed (3.31.2):
    - Appboy-iOS-SDK/Core
    - SDWebImage (< 6, >= 5.8.2)
  - Appboy-iOS-SDK/UI (3.31.2):
    - Appboy-iOS-SDK/ContentCards
    - Appboy-iOS-SDK/Core
    - Appboy-iOS-SDK/InAppMessage
    - Appboy-iOS-SDK/NewsFeed

NPM library

"react-native-appboy-sdk": "1.26.0"

Describe your environment.

Info Value
Platform Name react-native / ios
Platform Version 14
SDK Version 3.31.2
Integration Method cocoapods
Repro rate all the time (100%)

What did you do?

Sent IAM Modal with deep link and attempted to dismiss modal through accessing deep link (deep link functions) but the modal background is not dismissed.

What did you expect to happen?

The modal background to dismiss.

What happened instead?

The modal background did not dismiss.

chshapiro commented 3 years ago

Hey @lustig-bakkt,

Are you doing any customization for your in-app messages?

lustig-bakkt commented 3 years ago

Hey @lustig-bakkt,

Are you doing any customization for your in-app messages?

I have added a deeplink to one of the buttons and added a key value pair.

One interesting thing to note is that this is a React Native application and when run through the command line is when I saw this bug. If run through Xcode, it did not happen.

chshapiro commented 3 years ago

Hey @lustig-bakkt,

Are you still experiencing this issue?

lustig-bakkt commented 3 years ago

I think the issue is resolved but I forgot what we did to do so

chshapiro commented 3 years ago

👍 I'm going to close out the issue. Feel free to open a new one if you run into anything else.