search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
165 stars 142 forks source link

Add missing « DEFINES_MODULE » #298

Closed marclefrancois closed 2 years ago

marclefrancois commented 3 years ago

This is needed to include the SDK without to have to specify :modular_headers => true

lowip commented 3 years ago

Salut Marc, merci pour la PR!

We'll review that change internally to make sure that there's no unintended consequences / incompatibilities with other CocoaPods flags (e.g. a non-negligible part of our clients rely on use_frameworks!).

lowip commented 2 years ago

Hi Marc,

After investigating we have concluded that this change risks breaking a lot of clients' integrations. We recommend using :modular_headers => true on the Braze pod itself for now.