search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
164 stars 142 forks source link

XCFramework with Carthage for "Core" integration #318

Closed marcelofabri closed 2 years ago

marcelofabri commented 2 years ago

The Core integration does not support XCFrameworks, and you can use the original .framework files as before.

Any reason for that @hokstuff? That's the integration we've been using and would love to keep using it.

Originally posted by @marcelofabri in https://github.com/Appboy/appboy-ios-sdk/issues/293#issuecomment-952365598

hokstuff commented 2 years ago

Hi @marcelofabri,

Thanks for submitting this request! We initially added Carthage XCFramework support for the common use case of integrating the full SDK. We've now included adding XCFramework support for the Core integration to the roadmap as well, but we currently don't have a set timeline.

Best, Daniel

marcelofabri commented 2 years ago

Thanks @hokstuff! Just curious: is the Core framework distributed via Carthage the same as AppboyKitLibrary from SPM?

hokstuff commented 2 years ago

Hi @marcelofabri,

The Core framework for Carthage contains a dynamic framework that has bundle resources containing localization files, etc. The AppboyKitLibrary asset for SPM contains an XCFramework containing the static library, but without any resource files directly in it.

marcelofabri commented 2 years ago

Got it. I was hoping we could just use the binary from SPM but I guess that won't work due to the missing bundle.

I'd really appreciate if this could be prioritized and/or given a timeline, since this is one of our last remaining dependencies that don't support xcframework/arm64 slice for the simulator.

marcelofabri commented 2 years ago

@hokstuff Any updates here? Braze is our last dependency that doesn't support M1 Macs and we really want to stop using Rosetta.

hokstuff commented 2 years ago

Hi @marcelofabri,

Thanks for checking in! Pending any changes, we actually are planning to release Carthage Core XCFramework support in our next release which is planned fairly soon. We will update on this thread once it is ready - thanks for your patience!

hokstuff commented 2 years ago

Hi @marcelofabri,

We have released iOS SDK version 4.4.1 which contains XCFramework support for the Carthage Core integration as well as the Core XCFramework artifact, which contains the relevant non-UI resources. Let us know if you run into any issues - thank you!

Best, Daniel