search

Appboy / appboy-ios-sdk

Public repo for the Braze iOS SDK
https://www.braze.com
Other
164 stars 142 forks source link

[Feature]: Allow to set padding in the ABKCaptionedImageContentCardCell #336

Closed pchelnikov closed 2 years ago

pchelnikov commented 2 years ago

What problem are you facing?

I was trying to adjust some inner padding on the content cards and found out that I can't do that on the ABKCaptionedImageContentCardCell. Specifically for titleLabel, descriptionLabel, and linkLabel.

It's possible to adjust padding on the other cards, ABKClassicImageContentCardCell for example. But it's hardcoded for the ABKCaptionedImageContentCardCell (see this file: https://github.com/Appboy/appboy-ios-sdk/blob/master/AppboyUI/ABKContentCards/ViewControllers/Cells/ABKCaptionedImageContentCardCell.m#L163)

Workarounds

no

Ideal Solution

Would it be possible to allow us to adjust text padding on the ABKCaptionedImageContentCardCell by introducing some property/properties?

Other Information

No response

Bucimis commented 2 years ago

@pchelnikov thanks for filing this. We agree this is a shortcoming and have filed a story internally to fix. Are you able to use any workarounds or use the default padding for now?

pchelnikov commented 2 years ago

@Bucimis thanks for answering. I didn't find any workaround, so using the default padding for now.

hokstuff commented 2 years ago

Hi @pchelnikov,

We have released iOS SDK version 4.4.3 that addresses this issue. Thanks for filing!