Closed ovstetun closed 10 years ago
Any feedback on this issue?
Hi
Apologies for the delay, for some reason I was not notified by GitHub (probably some settings somewhere).
In principle, I have nothing against that option. So I will have a look at how to integrate your changes.
Note however that the branch is 4.0 and requires java8.
So it will require me to investigate a bit more...and have a bit more time, may be next weekend?
Thanks for your contribution,
Benoit
Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original
On 16 Jun 2014, at 08:33, "Trond Marius Øvstetun" notifications@github.com wrote:
Any feedback on this issue?
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46148566.
Thanks. I based the fork on the old tag, before the upgrade to java 8. The change should work also running J8, but my project is still running java 6 and will be for at least some time.
On Mon, Jun 16, 2014 at 9:45 AM, Benoit Xhenseval notifications@github.com wrote:
Hi
Apologies for the delay, for some reason I was not notified by GitHub (probably some settings somewhere).
In principle, I have nothing against that option. So I will have a look at how to integrate your changes.
Note however that the branch is 4.0 and requires java8.
So it will require me to investigate a bit more...and have a bit more time, may be next weekend?
Thanks for your contribution,
Benoit
Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original
On 16 Jun 2014, at 08:33, "Trond Marius Øvstetun" < notifications@github.com> wrote:
Any feedback on this issue?
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46148566.
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46149437.
TronD
We will have a look and try to do a 3.4.1 release (GitHub all a bit new to us). I assume that you've created a pull request?
Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original
On 16 Jun 2014, at 08:52, "Trond Marius Øvstetun" notifications@github.com wrote:
Thanks. I based the fork on the old tag, before the upgrade to java 8. The change should work also running J8, but my project is still running java 6 and will be for at least some time.
On Mon, Jun 16, 2014 at 9:45 AM, Benoit Xhenseval notifications@github.com
wrote:
Hi
Apologies for the delay, for some reason I was not notified by GitHub (probably some settings somewhere).
In principle, I have nothing against that option. So I will have a look at how to integrate your changes.
Note however that the branch is 4.0 and requires java8.
So it will require me to investigate a bit more...and have a bit more time, may be next weekend?
Thanks for your contribution,
Benoit
Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original
On 16 Jun 2014, at 08:33, "Trond Marius Øvstetun" < notifications@github.com> wrote:
Any feedback on this issue?
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46148566.
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46149437.
TronD
— Reply to this email directly or view it on GitHub https://github.com/Appendium/flatpack/pull/6#issuecomment-46149918.
working on it.. having fun with Git (not).. creating a 3_4_branch and pulling your changes there first. I'll try to organise a 3.4.1. release today but if I run out of time, I'll do it next week. I'll then apply your changes to MASTER.
Hi *, I believe that flatpack-3.4.1 has been released successfully to Maven central. Big thank you for your contribution. I will now merge it into 4.0
Added option on the Parser interface to preserve leading and/or trailing whitespace in columns. Kept the previous behaviour as default (preserving leading, trimming trailing).
I added this on top of 3.4.0, as we are in need of this on our project, running Java 6.