iPhoneOnly flag being used to set name filtering for Android, preventing Android tests from running

AppiumTestDistribution / appium-device-farm

This is an Appium 2.0 plugin designed to manage and create driver sessions on available devices.

https://devicefarm.org

Other

311 stars 97 forks source link

iPhoneOnly flag being used to set name filtering for Android, preventing Android tests from running #532

Open nextlevelbeard opened 1 year ago

nextlevelbeard commented 1 year ago

Have available simulators open.
Have available emulators open.
Pass plugin parameter --plugin-device-farm-platform=both
Start a single test session for an Android device, pass capability appium:iPhoneOnly

The flag should be ignored if platform is Android. Under these conditions, Android devices never became "available" because it attempts to filter the name as iPhone

saikrishna321 commented 1 year ago

Why are you providing iPhoneOnly caps when you know its going to be Android session?

nextlevelbeard commented 1 year ago

Makes no sense but I stumbled upon this when accidentally inheriting the capability from a base configuration. Best to make it ignored on Android to prevent users from also facing this issue. Either that or provide documentation warning users.

Figured reporting this can help someone.

saikrishna321 commented 1 year ago

Agree! Thanks for reporting your observation. Will fix this in the next release