search

AppiumTestDistribution / appium-gestures-plugin

Appium plugin designed to perform gestures using W3C Actions.
47 stars 13 forks source link

[Swipe] Can we make MAGIC_NUMBER a parameter? #100

Open agata-adamczewska-jt opened 1 year ago

agata-adamczewska-jt commented 1 year ago

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it. I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

dipakkumar1225 commented 10 months ago

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it. I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

yes, it will be good, if there is option to provide edge

saikrishna321 commented 10 months ago

We should definitely improve this to keep it more dynamic.