ApplaudSolutions / Applaud-Workato-Connector

Code pertaining to the Applaud Workato Connector
0 stars 0 forks source link

Lookup breakdown of Id and values are coming null post inelastic #52

Open kushalapplaud opened 1 year ago

kushalapplaud commented 1 year ago

Describe the bug Lookup breakdown of Id and values are coming null post inelastic

Steps to reproduce

  1. Navigate to https://dev-vmware-com.tryapplaud.com/recipes
  2. Select Converting numbers into html recipe
  3. Select jobs
  4. See error

Expected behavior The label of the lookup should come under values and id should come under id. Both are coming null

Screenshots This clearly shows that the lookup value is coming through.

image

Using the value under lookup in a variable, which is coming blank:-

image image

URL https://dev-vmware-com.tryapplaud.com/recipes

Additional context Changes were intially made in #43

Developer Testing

Requestor: leave this section blank Developer: complete this section during commit/pull request

Positive testing:

Add all the things that you have checked whilst completing this story here, it should be written in a non-technical way, and a lot of this can probably be taken from the acceptance criteria, here are two different examples:

Negative testing:

Here you list the things you have checked where your code needs to show an error, handle unusual/bad input/config gracefully, or may impact separate features that use or depend on the same code. Pause and think -- they may not be obvious! Examples:

e2e test links and description:

kushalapplaud commented 1 year ago

@ssarap @vinaykumarkasireddy This is urgent for Vmware. Could you please look into this as priority.

ssarap commented 1 year ago

@vinaykumarkasireddy I remember this has been tested during inelastic. Can you pls review this.

vinaykumarkasireddy commented 1 year ago

@kushalapplaud This is working fine in stage. Verified just now.

image image

Please check the configuration.

kushalapplaud commented 1 year ago

@vinaykumarkasireddy Please check if multiple lookups are present in a single model then what happens. My use case is that.

vinaykumarkasireddy commented 1 year ago

Created a model with multiple lookups. Able to get the values and ids in recipes.

image image
vinaykumarkasireddy commented 1 year ago

This is working fine in VMWare tenant also. Created a model 'lookuptests' with three lookup properties with the same labels 1,2,3,4 and 5. Able to fetch the id and value properties properly in recipes.

image image

@kushalapplaud Can you try this by recreating the model. I don't see any issue with the connector.

kushalapplaud commented 1 year ago

@vinaykumarkasireddy Thanks for checking this. Not sure why it is not working for that particular model then. I will try to delete the values in lookup and recreate again to see if it works.

ssarap commented 1 year ago

@kushalapplaud Can you check what is the API response.

kushalapplaud commented 1 year ago

@ssarap in API response I'm getting the id and also the lookup breakdown where it gives id and label. But I'm not getting that in the data pill.

vinaykumarkasireddy commented 1 year ago

Issue reproduced. Get response converting the spaces to hyphens when the property name includes spaces. Need to update the connector to handle this case.

kushalapplaud commented 1 year ago

@ssarap @vinaykumarkasireddy Any update on this?

ssarap commented 1 year ago

This will be fixed in Dec month end release.

vinaykumarkasireddy commented 1 year ago

@kushalapplaud Changes are done and present in 'vinay_connector'. Can you please check.